-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve code related to OAuth
section
#11954
Merged
ndom91
merged 4 commits into
nextauthjs:main
from
halvaradop:chore/improve-oauth-section
Dec 3, 2024
Merged
chore: improve code related to OAuth
section
#11954
ndom91
merged 4 commits into
nextauthjs:main
from
halvaradop:chore/improve-oauth-section
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the `useOAuthProviderSelect` hook - Cleaned up the `OAuthProviderInstructions` component - Introduced the new `PreviewProviders` component - Added the `useSelectCombobox` hook - Created a `hooks` folder and update the `tsconfig.json` paths
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@halvaradop is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
- Replace `getHighlighter` with `createHighlighter` - Ensure compatibility with existing functionality
ndom91
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just popped up on my radar again, looks good. Thanks!
falcowinkler
pushed a commit
to halvaradop/next-auth
that referenced
this pull request
Jan 5, 2025
* chore: improve code related to `OAuth` section - Removed the `useOAuthProviderSelect` hook - Cleaned up the `OAuthProviderInstructions` component - Introduced the new `PreviewProviders` component - Added the `useSelectCombobox` hook - Created a `hooks` folder and update the `tsconfig.json` paths * chore: update `highlighter` function - Replace `getHighlighter` with `createHighlighter` - Ensure compatibility with existing functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
This pull request refines the codebase related to the OAuth section to reduce redundancy and enhance flexibility. The changes focus on providing a more generalized structure, making it easier to implement new features like a search bar or adapt current code with minimal changes:
useOAuthProviderSelect
hookOAuthProviderInstructions
componentPreviewProviders
componentuseSelectCombobox
hookhooks
folder and update thetsconfig.json
paths🧢 Checklist
🎫 Affected issues
📌 Resources